Re: [PATCH] mspro_block: Fix an error code in mspro_block_issue_req()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 10, 2019 at 03:11:45PM +0200, walter harms wrote:
> If i see this correcly everybody leaving the loop making the function return something.
> I do not know how would do that but IMHO is better to be defensive and end the function
> with a propper return code (perhaps 0).
> 

It's a forever loop.  If we add another break statement without adding
at return then GCC will complain.

I feel like maybe you're saying that you don't like forever loops?  That
becomes a pretty complicated position to take...

regards,
dan carpenter




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux