Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: YueHaibing <yuehaibing@xxxxxxxxxx>
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
From: Andrew Lunn <andrew@xxxxxxx>
Date: Mon, 29 Apr 2019 15:56:03 +0200
Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>, Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>, linux-omap@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20190429135650.72794-1-yuehaibing@huawei.com>
References: <20190429135650.72794-1-yuehaibing@huawei.com>
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Apr 29, 2019 at 01:56:50PM +0000, YueHaibing wrote:
> Change the call to PTR_ERR to access the value just tested by IS_ERR.
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Please could you add a Fixes: tag.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew

Follow-Ups:
- Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
  - From: YueHaibing

References:
- [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
  - From: YueHaibing

Prev by Date: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Next by Date: [PATCH] mac80211: remove set but not used variable 'old'
Previous by thread: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Next by thread: Re: [PATCH net-next] net: ethernet: ti: cpsw: Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]