From: Colin King <colin.king@xxxxxxxxxxxxx> Date: Fri, 12 Apr 2019 15:13:27 +0100 > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The err2 error return path calls qede_ptp_disable that cleans up > on an error and frees ptp. After this, the free'd ptp is dereferenced > when ptp->clock is set to NULL and the code falls-through to error > path err1 that frees ptp again. > > Fix this by calling qede_ptp_disable and exiting via an error > return path that does not set ptp->clock or kfree ptp. > > Addresses-Coverity: ("Write to pointer after free") > Fixes: 035744975aec ("qede: Add support for PTP resource locking.") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Also applied, thanks Colin.