Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tomas Bortoli <tomasbortoli@xxxxxxxxx>
Subject: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Sat, 6 Apr 2019 00:23:04 +0300
Cc: Cong Wang <xiyou.wangcong@xxxxxxxxx>, Marcel Holtmann <marcel@xxxxxxxxxxxx>, Jaganath Kanakkassery <jaganath.k.os@xxxxxxxxx>, Johan Hedberg <johan.hedberg@xxxxxxxxx>, linux-bluetooth <linux-bluetooth@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <CAAHj5qj3PciY8ngqSGzH3=TQcm5vCghb0Z_0Y3DFQjTLMUM-9Q@mail.gmail.com>
References: <20190402063313.GA32613@kadam> <CAM_iQpW=X2X5A873nSPM7yLBiWZM+rsJk+uMpiOioYPFsFP9vg@mail.gmail.com> <20190402195537.GF32613@kadam> <CAM_iQpU2qwezhk8XdnX+kvUi8Oi0mwNxRuFOo8uGvjZaPZGNWA@mail.gmail.com> <20190404080627.GG32590@kadam> <CAM_iQpXLoSU5f4tGtwDt9=+AQ==4CfYhnxcOmKkmvB+Yd0KNfw@mail.gmail.com> <20190405204838.GR32590@kadam> <5344bfc8-ba02-c17f-c4cd-0418d48e6fdd@gmail.com> <20190405211414.GT32590@kadam> <CAAHj5qj3PciY8ngqSGzH3=TQcm5vCghb0Z_0Y3DFQjTLMUM-9Q@mail.gmail.com>
User-agent: Mutt/1.9.4 (2018-02-28)

I only deleted one unlikely() from around an unlikely(!pskb_may_pull())
check.  I made sure that the line numbers and debug symbols all stayed
exactly the same...  I just re-ran my experiment with the same results.

It's weird that you're getting different object code.  This stuff isn't
a new feature in GCC, it's at least 10 years old.

regards,
dan carpenter

References:
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Dan Carpenter
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Cong Wang
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Dan Carpenter
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Cong Wang
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Dan Carpenter
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Cong Wang
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Dan Carpenter
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Tomas Bortoli
- Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
Next by Date: [PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'
Previous by thread: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events
Next by thread: Re: [PATCH 1/2] scsi: pm8001: clean up structurally dead code when PM8001_USE_MSIX is defined
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]