Re: [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
From: Florian Westphal <fw@xxxxxxxxx>
Date: Fri, 5 Apr 2019 12:01:54 +0200
Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20190405083436.GT32613@kadam>
References: <20190402133038.GA18575@kadam> <20190405083436.GT32613@kadam>
User-agent: NeoMutt/20170113 (1.7.2)

Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 	if (hook->num > 31 || !(type->hook_mask & (1 << hook->num)))
> 
> which seems like a slightly ugly magic number but it fixes the buffer
> overflow.

You can use NF_MAX_HOOKS instead of 31.

References:
- [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
  - From: Dan Carpenter
- Re: [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
  - From: Dan Carpenter

Prev by Date: Re: [1/5] powerpc/sparse: fix possible object reference leak
Next by Date: Re: [PATCH -next] gpio: mlxbf: remove unused including <linux/version.h>
Previous by thread: Re: [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
Next by thread: [PATCH v2] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux