On Thu, Mar 28, 2019 at 9:21 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> We forgot to set "err" on this error path.
>
> Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied to fix branch. Thanks.
Regards,
Leo
> ---
> drivers/soc/fsl/qe/gpio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c
> index 819bed0f5667..51b3a47b5a55 100644
> --- a/drivers/soc/fsl/qe/gpio.c
> +++ b/drivers/soc/fsl/qe/gpio.c
> @@ -179,8 +179,10 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
> if (err < 0)
> goto err0;
> gc = gpio_to_chip(err);
> - if (WARN_ON(!gc))
> + if (WARN_ON(!gc)) {
> + err = -ENODEV;
> goto err0;
> + }
>
> if (!of_device_is_compatible(gc->of_node, "fsl,mpc8323-qe-pario-bank")) {
> pr_debug("%s: tried to get a non-qe pin\n", __func__);
> --
> 2.17.1
>
