Re: [PATCH v2] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()

Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> · Sun, 31 Mar 2019 12:03:59 +0800

Acked-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

Thanks!

--

Jiaxun Yang

在 2019/3/29 14:21, Dan Carpenter 写道:
Currently, when irq_domain_add_linear() fails, the error code does not
get so it returns zero which is wrong.  Fix it by setting appropriate
error code.

Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>
---
V2: Improve the commit message

  drivers/irqchip/irq-ls1x.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c
index 86b72fbd3b45..353111a10413 100644
--- a/drivers/irqchip/irq-ls1x.c
+++ b/drivers/irqchip/irq-ls1x.c
@@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node,
  					     NULL);
  	if (!priv->domain) {
  		pr_err("ls1x-irq: cannot add IRQ domain\n");
+		err = -ENOMEM;
  		goto out_iounmap;
  	}
  






