Re: [PATCH] scsi: qedi: remove declaration of nvm_image from stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Colin King <colin.king@xxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: qedi: remove declaration of nvm_image from stack
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Fri, 29 Mar 2019 10:04:53 -0400
Cc: QLogic-Storage-Upstream@xxxxxxxxxx, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20190327181103.15677-1-colin.king@canonical.com> (Colin King's message of "Wed, 27 Mar 2019 18:11:03 +0000")
Organization: Oracle Corporation
References: <20190327181103.15677-1-colin.king@canonical.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Colin,

> The nvm_image is a large struct qedi_nvm_iscsi_image object of over
> 24K so don't declare it on the stack just for a sizeof requirement;
> use sizeof on struct qedi_nvm_iscsi_image instead.

Applied to 5.1/scsi-fixes. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: qedi: remove declaration of nvm_image from stack
  - From: Colin King

Prev by Date: Re: [PATCH] scsi: pm8001: clean up structurally dead code when PM8001_USE_MSIX is defined
Next by Date: Re: [PATCH] scsi: pm8001: clean up structurally dead code when PM8001_USE_MSIX is defined
Previous by thread: RE: [PATCH] scsi: qedi: remove declaration of nvm_image from stack
Next by thread: [PATCH -next] gpio: mlxbf: remove unused including <linux/version.h>
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux