On Sat, Mar 16, 2019 at 11:05:12PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The variable len is not being inintialized and the uninitialized > value is being returned. However, this return path is never reached > because the default case in the switch statement returns -ENOSYS. > Clean up the code by replacing the return -ENOSYS with a break > for the default case and returning -ENOSYS at the end of the > function. This allows len to be removed. Also remove redundant > break that follows a return statement. > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx> > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> > --- > drivers/infiniband/ulp/iser/iscsi_iser.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied to for-next Thanks, Jason
