Acked-by: Jon Maloy <jon.maloy@xxxxxxxxxxxx>
> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx>
> On Behalf Of Wei Yongjun
> Sent: 25-Mar-19 07:31
> To: Jon Maloy <jon.maloy@xxxxxxxxxxxx>; Ying Xue
> <ying.xue@xxxxxxxxxxxxx>; Hoang Huu Le <hoang.h.le@xxxxxxxxxxxxxx>;
> Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; Hulk
> Robot <hulkci@xxxxxxxxxx>
> Subject: [PATCH net-next v2] tipc: fix return value check in
> tipc_mcast_send_sync()
>
> Fix the return value check which testing the wrong variable in
> tipc_mcast_send_sync().
>
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> v1 -> v2: add reported-by
> ---
> net/tipc/bcast.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index
> 88edfb358ae7..76e14dc08bb9 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net,
> struct sk_buff *skb,
>
> /* Allocate dummy message */
> _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> - if (!skb)
> + if (!_skb)
> return -ENOMEM;
>
> /* Preparing for 'synching' header */
>
>
