On 03/20/2019 12:14 PM, Mike Christie wrote: > On 03/20/2019 11:37 AM, Colin King wrote: >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> >> >> Currently an error return is being assigned to an unsigned >> size_t varianle and then checked if the result is less than >> zero which will always be false. Fix this by making ret > > What kernel version was this made against? > > For Martin's 5.2 queue branch, with these scsi changes it looks like > strlcpy returns a size_t. And then below it looks like we compare the > return value from that function to the buffer size and the max len of > the string we support. We do not seem to check for less than zero. > > My mistake. I was looking at len and not ret. Patch looks ok to me. Reviewed-by: Mike Christie <mchristi@xxxxxxxxxx>
