Re: [PATCH serial v4] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 20, 2019 at 10:25:31AM +0800, Mao Wenan wrote:
> Add the missing uart_unregister_driver() and i2c_del_driver() before
> return from sc16is7xx_init() in the error handling case.
> 
> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
> Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx>
> Reviewed-by: Dan Carpeter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
> ---
>  v1->v2: fix compile warning if CONFIG_SERIAL_SC16IS7XX_SPI is not exist.
>  v2->v3: create functions for i2c and spi to do error handling as dan carpenter suggestion.
>  v3->v4: As Greg suggestion, v4 is based on v1 and v3. 
>  drivers/tty/serial/sc16is7xx.c | 46 ++++++++++++++++++++++------------

Please use scripts/get_maintainers.pl for who to send patches to, and
what mailing list to cc: in the future.

thanks,

greg k-h



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux