Re: [PATCH] scsi: qla2xxx: check for kstrtol() failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: qla2xxx: check for kstrtol() failure
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 06 Mar 2019 19:19:30 -0500
Cc: qla2xxx-upstream@xxxxxxxxxx, Anil Gurumurthy <agurumurthy@xxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20190220053913.GA25196@kadam> (Dan Carpenter's message of "Wed, 20 Feb 2019 08:39:13 +0300")
Organization: Oracle Corporation
References: <20190220053913.GA25196@kadam>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Dan,

> The error handling was unintentionally left out so it introduces a
> Smatch static checker warning:
>
>     drivers/scsi/qla2xxx/qla_attr.c:1655 qla2x00_port_speed_store()
>     error: uninitialized symbol 'type'.

Applied to 5.1/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: qla2xxx: check for kstrtol() failure
  - From: Dan Carpenter

Prev by Date: Re: [PATCH net] net: hns3: Fix a logical vs bitwise typo
Next by Date: [PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()
Previous by thread: [PATCH] scsi: qla2xxx: check for kstrtol() failure
Next by thread: [PATCH] IB/iser: Fix some error handling in iser_fast_reg_fmr()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux