Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Subject: Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 28 Feb 2019 21:01:31 +0300
Cc: Alexei Starovoitov <ast@xxxxxxxxxx>, Andrii Nakryiko <andriin@xxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <kafai@xxxxxx>, Song Liu <songliubraving@xxxxxx>, Yonghong Song <yhs@xxxxxx>, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20190228175300.GB9508@kernel.org>
References: <a34432d0-b838-c004-ef79-052cd50996c0@fb.com> <20190228175035.GA30148@kadam> <20190228175300.GB9508@kernel.org>
User-agent: Mutt/1.9.4 (2018-02-28)

On Thu, Feb 28, 2019 at 02:53:00PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 28, 2019 at 08:50:35PM +0300, Dan Carpenter escreveu:
> > The "ref_type_id" variable needs to be signed for the error handling
> > to work.
> 
> Does the infiniband signedness change comes as a bonus? :-)
> 

Oh wow...  :P

Let me resend v3.

regards,
dan carpenter

References:
- Re: [PATCH] tools/libbpf: signedness bug in btf_dedup_ref_type()
  - From: Yonghong Song
- [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
  - From: Dan Carpenter
- Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
  - From: Arnaldo Carvalho de Melo

Prev by Date: Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
Next by Date: [PATCH v3] tools/libbpf: signedness bug in btf_dedup_ref_type()
Previous by thread: Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
Next by thread: [PATCH v3] tools/libbpf: signedness bug in btf_dedup_ref_type()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]