On 23-02-19, 14:20, Julia Lawall wrote: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_node_put(e) > when != x = e > when != e = x > when any > if (<+...of_device_is_available(e)...+>) { > ... when != of_node_put(e) > ( > return e; > | > + of_node_put(e); > return ...; > ) > } > // </smpl> > > Fixes: f525a670533d9 ("cpufreq: ap806: add cpufreq driver for Armada 8K") > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > drivers/cpufreq/armada-8k-cpufreq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -u -p a/drivers/cpufreq/armada-8k-cpufreq.c b/drivers/cpufreq/armada-8k-cpufreq.c > --- a/drivers/cpufreq/armada-8k-cpufreq.c > +++ b/drivers/cpufreq/armada-8k-cpufreq.c > @@ -128,8 +128,10 @@ static int __init armada_8k_cpufreq_init > struct cpumask cpus; > > node = of_find_compatible_node(NULL, NULL, "marvell,ap806-cpu-clock"); > - if (!node || !of_device_is_available(node)) > + if (!node || !of_device_is_available(node)) { > + of_node_put(node); > return -ENODEV; > + } > > nb_cpus = num_possible_cpus(); > freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL); Applied. Thanks. -- viresh
