Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 22 Feb 2019 10:29:14 +0300
Cc: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20190221115426.f616100906d989eda93d66dc@linux-foundation.org>
References: <20190221183700.GA1737@kadam> <20190221183826.GA30993@kadam> <20190221105458.409d1968961962079c54b815@linux-foundation.org> <20190221191855.GB1737@kadam> <20190221115426.f616100906d989eda93d66dc@linux-foundation.org>
User-agent: Mutt/1.9.4 (2018-02-28)

I've looked at this some more and I don't think it's a good idea to
change the type of U8_MAX.  Right now INT_MAX is int and USHRT_MAX is
unsigned short etc.  That's the only intuitive thing for them to be.

regards,
dan carpenter

References:
- [PATCH 1/2] test_firmware: remove some dead code
  - From: Dan Carpenter
- [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
  - From: Dan Carpenter
- Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
  - From: Andrew Morton
- Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
  - From: Dan Carpenter
- Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
  - From: Andrew Morton

Prev by Date: Re: [PATCH -next] habanalabs: use GFP_ATOMIC under spin lock
Next by Date: Re: [PATCH -next] habanalabs: use GFP_ATOMIC under spin lock
Previous by thread: Re: [PATCH 2/2] test_firmware: silence underflow warning in test_dev_config_update_u8()
Next by thread: Re: [PATCH -next] drm/bridge: cdns: Remove set but not used variable 'bpp'
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]