On Wed, 20 Feb 2019 at 22:03, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Feb 20, 2019 at 09:55:50PM +0530, Sumit Garg wrote: > > Hi Arnd, > > > > On Wed, 20 Feb 2019 at 21:04, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > > > > > On Wed, Feb 20, 2019 at 12:17 PM Sumit Garg <sumit.garg@xxxxxxxxxx> wrote: > > > > > > > > On Wed, 20 Feb 2019 at 16:19, Colin Ian King <colin.king@xxxxxxxxxxxxx> wrote: > > > > > > > > > > On 20/02/2019 10:37, Ard Biesheuvel wrote: > > > > > > On Wed, 20 Feb 2019 at 11:34, Sumit Garg <sumit.garg@xxxxxxxxxx> wrote: > > > > > >> > > > > > >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote: > > > > > >>> > > > > > >>> Fixes the following sparse warning: > > > > > >>> > > > > > >>> drivers/char/hw_random/optee-rng.c:265:35: warning: > > > > > >>> symbol 'optee_rng_id_table' was not declared. Should it be static? > > > > > >>> > > > > > >> > > > > > >> I haven't observed this warning during my normal Linux build using > > > > > >> gcc. Is there any specific configuration you are using? > > > > > >> > > > > > > > > > > > > This is a sparse warning, not GCC. You need to install it separately > > > > > > and build with C=1 (iirc) > > > > > > > > > > > > > > TBH, I wasn't aware about this sparse tool. I did install sparse and > > > > build with C=1 option. But I could only get following such > > > > errors/warnings for drivers/char/hw_random/optee-rng.c: > > > > > > > > ./arch/arm64/include/asm/lse.h:18:37: warning: Unknown escape 'l' > > > > ./arch/arm64/include/asm/alternative.h:213:28: warning: Unknown escape 'o' > > > > ./include/linux/compiler.h:194:8: error: attribute '__gnu_inline__': > > > > unknown attribute > > > > > > > > But not the one mentioned in this patch. > > > > > > Not sure what went wrong, I see the same warning as the others. > > > Maybe you have an outdated version of sparse that runs into unrelated > > > issues? > > > > > > > $ apt list sparse > > Listing... Done > > sparse/xenial,now 0.5.0-1build1 amd64 [installed] > > Ick, really obsolete, please use the sparse version on kernel.org for > kernel stuff: > git://git.kernel.org/pub/scm/devel/sparse/sparse.git > > Loads of things have been fixed and resolved from 0.5.0 which is very > old. > Thanks for this info. Now it works pretty well. -Sumit > thanks, > > greg k-h
