On Wed, Feb 20, 2019 at 4:23 AM Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote: > > Fixes the following sparse warning: > > drivers/char/hw_random/optee-rng.c:265:35: warning: > symbol 'optee_rng_id_table' was not declared. Should it be static? Static limits visibility to the current translation unit. Static is like private visibility. Maybe you are thinking if it should be declared extern so other translation units can find the symbol. extern is like public visibility. Jeff