On Mon, Feb 11, 2019 at 09:32:10PM +0300, Dan Carpenter wrote: > We should drop the lock on this error path. This is from static > analysis and I don't know if it's possible to hit this error path in > real life. Yes the lock needs to be released, it's there to protect access to the dev_replace members and is not supposed to be left locked. The value of state that's being switched would need to be artifically changed to an invalid value so the default: branch is taken. It's been introduced by d189dd70e25561817325 in 5.0-rc1 so it counts as a regression but I don't think it's urgent enough to be sent to a late rc. It'll go through the stable tree channel. Thanks.
