Enric, You should take that one or squash it with the original commit. On 16/02/2019 01:36:03+0000, Wei Yongjun wrote: > Fixes the following sparse warnings: > > drivers/rtc/rtc-wilco-ec.c:72:5: warning: > symbol 'wilco_ec_rtc_read' was not declared. Should it be static? > drivers/rtc/rtc-wilco-ec.c:106:5: warning: > symbol 'wilco_ec_rtc_write' was not declared. Should it be static? > > Fixes: 79c4ec4869b5 ("platform/chrome: wilco_ec: Add RTC driver") > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > drivers/rtc/rtc-wilco-ec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-wilco-ec.c b/drivers/rtc/rtc-wilco-ec.c > index 35cc56114c1c..e62bda0cb53e 100644 > --- a/drivers/rtc/rtc-wilco-ec.c > +++ b/drivers/rtc/rtc-wilco-ec.c > @@ -69,7 +69,7 @@ struct ec_rtc_write { > u8 weekday; > } __packed; > > -int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm) > +static int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm) > { > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent); > u8 param = EC_CMOS_TOD_READ; > @@ -103,7 +103,7 @@ int wilco_ec_rtc_read(struct device *dev, struct rtc_time *tm) > return 0; > } > > -int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm) > +static int wilco_ec_rtc_write(struct device *dev, struct rtc_time *tm) > { > struct wilco_ec_device *ec = dev_get_drvdata(dev->parent); > struct ec_rtc_write rtc; > > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com