RE: [PATCH net-next] bnx2x: Remove set but not used variable 'mfw_vn'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>-----Original Message-----
>From: YueHaibing [mailto:yuehaibing@xxxxxxxxxx]
>Sent: 18 February 2019 17:50
>To: Ariel Elior <aelior@xxxxxxxxxxx>; Sudarsana Reddy Kalluru
><skalluru@xxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>
>Cc: YueHaibing <yuehaibing@xxxxxxxxxx>; GR-everest-linux-l2 <GR-everest-
>linux-l2@xxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; kernel-
>janitors@xxxxxxxxxxxxxxx
>Subject: [PATCH net-next] bnx2x: Remove set but not used variable 'mfw_vn'
>
>Fixes gcc '-Wunused-but-set-variable' warning:
>
>drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function
>'bnx2x_get_hwinfo':
>drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:11940:10: warning:
> variable 'mfw_vn' set but not used [-Wunused-but-set-variable]
>
>It's never used since introduction.
>
>Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>---
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>index 3b5b47e98c73..7c47be215a34 100644
>--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
>@@ -11998,7 +11998,7 @@ static void validate_set_si_mode(struct bnx2x
>*bp)  static int bnx2x_get_hwinfo(struct bnx2x *bp)  {
> 	int /*abs*/func = BP_ABS_FUNC(bp);
>-	int vn, mfw_vn;
>+	int vn;
> 	u32 val = 0, val2 = 0;
> 	int rc = 0;
>
>@@ -12083,12 +12083,10 @@ static int bnx2x_get_hwinfo(struct bnx2x *bp)
> 	/*
> 	 * Initialize MF configuration
> 	 */
>-
> 	bp->mf_ov = 0;
> 	bp->mf_mode = 0;
> 	bp->mf_sub_mode = 0;
> 	vn = BP_VN(bp);
>-	mfw_vn = BP_FW_MB_IDX(bp);
>
> 	if (!CHIP_IS_E1(bp) && !BP_NOMCP(bp)) {
> 		BNX2X_DEV_INFO("shmem2base 0x%x, size %d, mfcfg offset
>%d\n",
>
>

Acked-by: Sudarsana Reddy Kalluru <skalluru@xxxxxxxxxxx>




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux