Re: [PATCH net-next] cfg80211: pmsr: use eth_broadcast_addr() to assign broadcast address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Add kalle Valo in mail list.

Hi Kalle Valo,
Do you have any comments about this patch?

On 2019/2/16 17:47, Mao Wenan wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
> 
> Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx>
> ---
>  net/wireless/pmsr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/wireless/pmsr.c b/net/wireless/pmsr.c
> index de9286703280..21139b82749f 100644
> --- a/net/wireless/pmsr.c
> +++ b/net/wireless/pmsr.c
> @@ -258,7 +258,7 @@ int nl80211_pmsr_start(struct sk_buff *skb, struct genl_info *info)
>  	} else {
>  		memcpy(req->mac_addr, nla_data(info->attrs[NL80211_ATTR_MAC]),
>  		       ETH_ALEN);
> -		memset(req->mac_addr_mask, 0xff, ETH_ALEN);
> +		eth_broadcast_addr(req->mac_addr_mask);
>  	}
>  
>  	idx = 0;
> 




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux