In case of error, the function dma_buf_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> --- drivers/misc/fastrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 4b0db33896df..7edceaa6adaa 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -496,8 +496,8 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd, map->fl = fl; map->fd = fd; map->buf = dma_buf_get(fd); - if (!map->buf) { - err = -EINVAL; + if (IS_ERR(map->buf)) { + err = PTR_ERR(map->buf); goto get_err; }