On 2/13/19 10:13 PM, David Miller wrote: > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Date: Wed, 13 Feb 2019 11:23:04 +0300 > >> The value of ->num_ports comes from bcm_sf2_sw_probe() and it is less >> than or equal to DSA_MAX_PORTS. The ds->ports[] array is used inside >> the dsa_is_user_port() and dsa_is_cpu_port() functions. The ds->ports[] >> array is allocated in dsa_switch_alloc() and it has ds->num_ports >> elements so this leads to a static checker warning about a potential out >> of bounds read. This would not happen here because bcm_sf2 calls b53_switch_alloc() which does allocate the full port range (not for a good reason), but it's good to fix that anyways. >> >> Fixes: 8cfa94984c9c ("net: dsa: bcm_sf2: add suspend/resume callbacks") >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Applied. > -- Florian