On 2019/2/13 11:32, Chao Yu wrote: > On 2019/2/12 2:45, Dan Carpenter wrote: >> We put an upper bound on ->write_io_size_bits but we don't have a lower >> bound. > > Oh, lower bound, I think there are more cases didn't consider that, > let me check it. Sorry, one missing case: Shouldn't it be: if (arg <= 0 || arg > __ilog2_u32(BIO_MAX_PAGES)) { ^ > >> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> > > Thanks, > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >