Re: [PATCH] Input: msm: Tweak an error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 09, 2019 at 12:01:06PM +0300, Dan Carpenter wrote:
> The PTR_ERR(NULL) value is zero and it's not useful to print that.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied, thank you.

> ---
>  drivers/input/misc/msm-vibrator.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c
> index c06941021447..69f2579c4ec2 100644
> --- a/drivers/input/misc/msm-vibrator.c
> +++ b/drivers/input/misc/msm-vibrator.c
> @@ -199,8 +199,7 @@ static int msm_vibrator_probe(struct platform_device *pdev)
>  	vibrator->base = devm_ioremap(&pdev->dev, res->start,
>  				     resource_size(res));
>  	if (!vibrator->base) {
> -		dev_err(&pdev->dev, "Failed to iomap resource: %ld\n",
> -			PTR_ERR(vibrator->base));
> +		dev_err(&pdev->dev, "Failed to iomap resource.\n");
>  		return -ENOMEM;
>  	}
>  
> -- 
> 2.17.1
> 

-- 
Dmitry



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux