On Fri, Jan 18, 2019 at 9:18 AM Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:
>
> Fix to return a negative error code -ENOMEM from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 31696241e96e ("selinux: convert to kvmalloc")
Unfortunately this commit isn't to be found in any of the SELinux
branches, or Linus' master branch; based on the subject line I'm
guessing the original patch is in a -next branch somewhere. Please
find whoever pushed this patch to linux-next and have them apply the
fix.
Thank you.
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> security/selinux/ss/policydb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c
> index 6b576e5..ef616dd 100644
> --- a/security/selinux/ss/policydb.c
> +++ b/security/selinux/ss/policydb.c
> @@ -2490,6 +2490,7 @@ int policydb_read(struct policydb *p, void *fp)
> if (rc)
> goto bad;
>
> + rc = -ENOMEM;
> p->type_attr_map_array = kvcalloc(p->p_types.nprim,
> sizeof(*p->type_attr_map_array),
> GFP_KERNEL);
>
>
>
--
paul moore
www.paul-moore.com
