Re: [PATCH 1/3] mm: add include files so that function definitions have a prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Any chance these three patches of mine (reviewed by Mike Rapoport) 
will get merged?

Thanks for considering,

-d

P.S.: If they already got merged, I apologize—I couldn't find a 
repo for mm. (I checked master and next.)

On Tue, Dec 4, 2018 at 02:14 -0300, Adeodato Simó <dato@xxxxxxxxxxxxxx> wrote:
> Previously, rodata_test(), usercopy_warn(), and usercopy_abort() were
> defined without a matching prototype. Detected by -Wmissing-prototypes
> GCC flag.
> 
> Signed-off-by: Adeodato Simó <dato@xxxxxxxxxxxxxx>
> ---
> I started poking at this after kernel-janitors got the suggestion[1]
> to look into the -Wmissing-prototypes warnings.
> 
> Thanks for considering!
> 
> [1]: https://www.spinics.net/lists/linux-kernel-janitors/msg43981.html
> 
>  mm/rodata_test.c | 1 +
>  mm/usercopy.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/mm/rodata_test.c b/mm/rodata_test.c
> index d908c8769b48..01306defbd1b 100644
> --- a/mm/rodata_test.c
> +++ b/mm/rodata_test.c
> @@ -11,6 +11,7 @@
>   */
>  #define pr_fmt(fmt) "rodata_test: " fmt
>  
> +#include <linux/rodata_test.h>
>  #include <linux/uaccess.h>
>  #include <asm/sections.h>
>  
> diff --git a/mm/usercopy.c b/mm/usercopy.c
> index 852eb4e53f06..f487ba4888df 100644
> --- a/mm/usercopy.c
> +++ b/mm/usercopy.c
> @@ -20,6 +20,7 @@
>  #include <linux/sched/task.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/thread_info.h>
> +#include <linux/uaccess.h>
>  #include <linux/atomic.h>
>  #include <linux/jump_label.h>
>  #include <asm/sections.h>
> -- 
> 2.19.2
> 



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux