Sorry, please ignore this patch, missing reviewed-by line, I will send a new version. > -----Original Message----- > From: weiyongjun (A) > Sent: Wednesday, January 16, 2019 6:39 PM > To: gregkh@xxxxxxxxxxxxxxxxxxx; arve@xxxxxxxxxxx; tkjos@xxxxxxxxxxx; > maco@xxxxxxxxxxx; joel@xxxxxxxxxxxxxxxxx; christian@xxxxxxxxxx > Cc: weiyongjun (A) <weiyongjun1@xxxxxxxxxx>; > devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kernel- > janitors@xxxxxxxxxxxxxxx > Subject: [PATCH v3] binderfs: fix error return code in binderfs_fill_super() > > Fix to return a negative error code -ENOMEM from the new_inode() and > d_make_root() error handling cases instead of 0, as done elsewhere in > this function. > > Fixes: 849d540ddfcd ("binderfs: implement "max" mount option") > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > --- > v1 -> v2: move 'ret = -ENOMEM' out of if > v2 -> v3: use correct fixes commit > --- > drivers/android/binderfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c > index 9518e2e..e4ff4c3 100644 > --- a/drivers/android/binderfs.c > +++ b/drivers/android/binderfs.c > @@ -518,6 +518,7 @@ static int binderfs_fill_super(struct super_block *sb, > void *data, int silent) > > sb->s_fs_info = info; > > + ret = -ENOMEM; > inode = new_inode(sb); > if (!inode) > goto err_without_dentry; > >