Am Montag, 14. Januar 2019, 11:05:56 CET schrieb Daniel Vetter: > On Sun, Jan 13, 2019 at 07:48:49PM +0100, Heiko Stuebner wrote: > > Am Sonntag, 13. Januar 2019, 09:47:43 CET schrieb Julia Lawall: > > > The device node iterators perform an of_node_get on each iteration, so a > > > jump out of the loop requires an of_node_put. > > > > > > The semantic patch that fixes this problem is as follows > > > (http://coccinelle.lip6.fr): > > > > > > // <smpl> > > > @@ > > > expression root,e; > > > local idexpression child; > > > iterator name for_each_child_of_node; > > > @@ > > > > > > for_each_child_of_node(root, child) { > > > ... when != of_node_put(child) > > > when != e = child > > > + of_node_put(child); > > > ? break; > > > ... > > > } > > > ... when != child > > > // </smpl> > > > > > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > I've added a fixes+stable tag and applied it to drm-misc-fixes > > All of them or just this one here? These cleanup patches have a high > chance of falling through cracks, so taking them all usually works out > better ... That is the only one I got, so right now I only applied this one in my inbox. Weekend and such resulted in me not going looking for other ones. Heiko
