On 09/01/2019 22:54, Michael Ellerman wrote:
> Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
>> There is a typo so we accidentally allocate enough memory for a pointer
>> when we wanted to allocate enough for a struct.
>>
>> Fixes: 0bd971676e68 ("powerpc/powernv/npu: Add compound IOMMU groups")
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>> ---
>> arch/powerpc/platforms/powernv/npu-dma.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks, I've applied this to my fixes-test tree.
>
> Alexey can you send me an ack?
Ouch.
Reviewed-by: Alexey Kardashevskiy <aik@xxxxxxxxx>
>
> cheers
>
>> diff --git a/arch/powerpc/platforms/powernv/npu-dma.c b/arch/powerpc/platforms/powernv/npu-dma.c
>> index d7f742ed48ba..3f58c7dbd581 100644
>> --- a/arch/powerpc/platforms/powernv/npu-dma.c
>> +++ b/arch/powerpc/platforms/powernv/npu-dma.c
>> @@ -564,7 +564,7 @@ struct iommu_table_group *pnv_try_setup_npu_table_group(struct pnv_ioda_pe *pe)
>> }
>> } else {
>> /* Create a group for 1 GPU and attached NPUs for POWER8 */
>> - pe->npucomp = kzalloc(sizeof(pe->npucomp), GFP_KERNEL);
>> + pe->npucomp = kzalloc(sizeof(*pe->npucomp), GFP_KERNEL);
>> table_group = &pe->npucomp->table_group;
>> table_group->ops = &pnv_npu_peers_ops;
>> iommu_register_group(table_group, hose->global_number,
>> --
>> 2.17.1
--
Alexey
