Re: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 09, 2019 at 11:27:47AM +0300, Dan Carpenter wrote:
> "ret" only holds zero and negative error codes.  It needs to be signed
> for the error handling to work.
> 
> Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

I would have expected a compiler warning but at least for me there is
none emitted. Hmm.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

@Thierry: Given that this is a fix I assume you want to apply this patch
before my pwm-imx series (which is cleanup only). This will conflict for
sure with my driver splitting patch. Please tell me if/when I should
resend my series rebased on top of this patch.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux