On 2019/1/2 18:55, Dan Carpenter wrote: > On Fri, Dec 28, 2018 at 09:58:04AM +0100, Michal Hocko wrote: >> On Fri 28-12-18 02:46:30, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning when >>> CONFIG_VMAP_STACK is not set: >> >> Isn't this warning disabled? I can see the following >> # These warnings generated too much noise in a regular build. >> # Use make W=1 to enable them (see scripts/Makefile.extrawarn) >> KBUILD_CFLAGS += -Wno-unused-but-set-variable >> >> in the main makefile. IMHO this warning doesn't really give us much. >> > > It would be nice to enable that warning. YueHaibing and Colin King have > been whittling away at the problematic code... > > YueHaibing, how many of these warnings do we have remaining on an > allmodoconfig? about 1300+ > > regards, > dan carpenter > > > . >
