On Sun, Dec 23, 2018 at 09:57:03AM +0100, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares has never > been used. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // </smpl> > > Fixes: 26f1fe858f274 ("xfs: reduce lock hold times in buffer writeback") > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Looks ok; are you planning to push this whole series directly to Linus or do you want me to take the two xfs patches through? Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > > --- > Successfully 0-day tested on 151 configurations. > > fs/xfs/xfs_buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index b21ea2ba768d..eedc5e0156ff 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -1992,7 +1992,6 @@ xfs_buf_delwri_submit_buffers( > struct list_head *wait_list) > { > struct xfs_buf *bp, *n; > - LIST_HEAD (submit_list); > int pinned = 0; > struct blk_plug plug; > >
