From: Colin Ian King <colin.king@xxxxxxxxxxxxx> The check for num_sge < 0 is always false because num_sge is not signed, fix this by declaring it as an int. Detected by CoverityScan, CID#1476005 ("Unsigned compared against 0") Fixes: ad8a4496757f ("IB/uverbs: Add support to advise_mr") Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- drivers/infiniband/core/uverbs_std_types_mr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/uverbs_std_types_mr.c b/drivers/infiniband/core/uverbs_std_types_mr.c index 71dfa5e5938e..4d4be0c2b752 100644 --- a/drivers/infiniband/core/uverbs_std_types_mr.c +++ b/drivers/infiniband/core/uverbs_std_types_mr.c @@ -47,7 +47,7 @@ static int UVERBS_HANDLER(UVERBS_METHOD_ADVISE_MR)( enum ib_uverbs_advise_mr_advice advice; struct ib_device *ib_dev = pd->device; struct ib_sge *sg_list; - u32 num_sge; + int num_sge; u32 flags; int ret; -- 2.19.1