Re: [PATCH] smack: Fix a memory leak in smack_add_opt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] smack: Fix a memory leak in smack_add_opt()
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Fri, 21 Dec 2018 16:36:54 +0000
Cc: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, linux-security-module@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20181221090958.GE2735@kadam>
References: <20181221090958.GE2735@kadam>
User-agent: Mutt/1.10.1 (2018-07-13)

On Fri, Dec 21, 2018 at 12:09:58PM +0300, Dan Carpenter wrote:
> The function is leaking "opts" on the error paths.
> 
> Fixes: 90e3b564ab93 ("smack: take the guts of smack_parse_opts_str() into a new helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

D'oh...  Applied, thanks for spotting that braino.

Follow-Ups:
- Re: [PATCH] smack: Fix a memory leak in smack_add_opt()
  - From: Al Viro

References:
- [PATCH] smack: Fix a memory leak in smack_add_opt()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] ASoC: pcm512x: Fix a double unlock in pcm512x_digital_mute()
Next by Date: Re: [PATCH] smack: Fix a memory leak in smack_add_opt()
Previous by thread: [PATCH] smack: Fix a memory leak in smack_add_opt()
Next by thread: Re: [PATCH] smack: Fix a memory leak in smack_add_opt()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux