On Tue, Dec 18, 2018 at 08:54:36AM +0000, Leonard Crestez wrote:
> On Tue, 2018-12-18 at 11:23 +0300, Dan Carpenter wrote:
> > The device_link_add() function doesn't return error pointers, it returns
> > NULL if there is an error.
> >
> > Fixes: 7a6991159bcd ("PCI: imx: Add multi-pd support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Reviewed-by: Leonard Crestez <leonard.crestez@xxxxxxx>
>
> I assume this was found with a static checker?
It's an unpublished Smatch check... It complains about running IS_ERR()
on things which aren't an error pointer. The problem is that that
happens all the time intentionally so i haven't published it. I should
probably make a version which only complains if it is an assignment from
a function that returns NULL.
(Even then it's problematic because it can depend on the .config)
regards,
dan carpenter
