On Fri, Nov 30, 2018 at 03:58:34PM +0300, Dan Carpenter wrote: > The pps_register_source() function doesn't return NULL, it returns > error pointers. It keeps a local variable for errno, but then it returns NULL. But this is about to change with this recent patch: 26.Nov'18 YueHaibing [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails It hasn't been merged yet AFAICT, but gregkh said he take it. Thanks, Richard