Re: [PATCH][net-next] net: phy: check if advertising is zero using linkmode_empty

Andrew Lunn <andrew@xxxxxxx> · Tue, 13 Nov 2018 01:18:01 +0100

On Mon, Nov 12, 2018 at 11:45:56PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> A recent change modified variable advertising from a u32 to a link mode
> array and left the u32 zero comparison, so essential we now have an array
> being compared to null which is not the intention. Fix this by using the
> call to linkmode_empty to check if advertising is all zero.
> 
> Detected by CoverityScan, CID#1475424 ("Array compared against 0")
> 
> Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks Colin.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew