On Thu, 2018-11-08 at 02:04 +0000, YueHaibing wrote:
> There is no need to have the '__be32 *p' variable static since new
> value
> always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index 2bbb8d3..d80b156 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -546,7 +546,7 @@ void xdr_commit_encode(struct xdr_stream *xdr)
> static __be32 *xdr_get_next_encode_buffer(struct xdr_stream *xdr,
> size_t nbytes)
> {
> - static __be32 *p;
> + __be32 *p;
> int space_left;
> int frag1bytes, frag2bytes;
>
Ouch, that's a really nasty bug that could definitely cause corruption
if you have 2 threads simultaneously calling this function! This really
deserves to be a stable patch.
Thank you, YueHaibing!
Bruce, do you want to shepherd this one in?
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@xxxxxxxxxxxxxxx
