> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On > Behalf Of Colin King > Sent: Friday, October 19, 2018 11:16 AM > To: Neftin, Sasha <sasha.neftin@xxxxxxxxx>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@xxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; > intel-wired-lan@xxxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [Intel-wired-lan] [PATCH][next] igc: fix error return handling from > call to netif_set_real_num_tx_queues > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The call to netif_set_real_num_tx_queues is not assigning the error > return to variable err even though the next line checks err for an > error. Fix this by adding the missing err assignment. > > Detected by CoverityScan, CID#1474551 ("Logically dead code") > > Fixes: 3df25e4c1e66 ("igc: Add interrupt support") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/net/ethernet/intel/igc/igc_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>