> From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev- > owner@xxxxxxxxxxxxxxx] On Behalf Of YueHaibing > Sent: Friday, October 19, 2018 5:41 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; Neftin, Sasha > <sasha.neftin@xxxxxxxxx> > Cc: YueHaibing <yuehaibing@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, > link_mode' > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_init_phy_params_base': > drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning: > variable 'ctrl_ext' set but not used [-Wunused-but-set-variable] > u32 ctrl_ext; > > drivers/net/ethernet/intel/igc/igc_base.c: In function > 'igc_get_invariants_base': > drivers/net/ethernet/intel/igc/igc_base.c:290:6: warning: > variable 'link_mode' set but not used [-Wunused-but-set-variable] > u32 link_mode = 0; > > It never used since introduction in > commit c0071c7aa5fe ("igc: Add HW initialization code") > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > I'm not sure that reading IGC_CTRL_EXT is necessary. > --- > drivers/net/ethernet/intel/igc/igc_base.c | 8 -------- > 1 file changed, 8 deletions(-) > Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>