On Thu, Oct 25, 2018 at 2:44 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> This function is supposed to return zero on success or negative error
> codes on error. Unfortunately, there is a bug so it sometimes returns
> non-zero, positive numbers on success.
>
> I noticed this bug during review and I can't test it. It does appear
> that the return is sometimes propogated back to _regmap_read() where all
> non-zero returns are treated as failure so this may affect run time.
>
> Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> v2: In v1, I introduced an new error path and forgot to drop the lock.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
I've got some cleanup work to do with this driver.
Getting to it.
Yours,
Linus Walleij
