Re: [PATCH 3/3] scsi: myrs: prevent negatives in disable_enclosure_messages_store()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] scsi: myrs: prevent negatives in disable_enclosure_messages_store()
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Tue, 23 Oct 2018 22:28:01 -0400
Cc: Hannes Reinecke <hare@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20181020084203.pime6kadzboxrds7@mwanda> (Dan Carpenter's message of "Sat, 20 Oct 2018 11:42:17 +0300")
Organization: Oracle Corporation
References: <20181019091909.a22ah7wybj6agqch@kili.mountain> <20181020084203.pime6kadzboxrds7@mwanda>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Dan,

>> +	if (value < 0 || value > 2)
>>  		return -EINVAL;
>
> It's not actually clear to me why we allow 2.  Shouldn't we just use
> kstrtobool()?

Hannes?

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH 3/3] scsi: myrs: prevent negatives in disable_enclosure_messages_store()
  - From: Dan Carpenter
- Re: [PATCH 3/3] scsi: myrs: prevent negatives in disable_enclosure_messages_store()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH -next] mvsas: Remove set but not used variable 'id'
Next by Date: [PATCH net-next] octeontx2-af: Copy the right amount of memory
Previous by thread: Re: [PATCH 3/3] scsi: myrs: prevent negatives in disable_enclosure_messages_store()
Next by thread: [PATCH net-next] rocker: Drop pointless static qualifier
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux