Re: [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

On 11-10-18 09:59, Dan Carpenter wrote:
> We need to unlock before returning on this error path.
>
> Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks, the kbuild test robot had already notified me about this
but I did not get around to fixing it yet.

Fix looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans

> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index 042e4f384df9..78a9c9b13ff6 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -424,6 +424,7 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,
>   	/* pinning is done in prepare/cleanup framebuffer */
>   	src = vbox_bo_kmap(bo);
>   	if (IS_ERR(src)) {
> +		mutex_unlock(&vbox->hw_mutex);
>   		DRM_WARN("Could not kmap cursor bo, skipping update\n");
>   		return;
>   	}