Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe()

Quentin Schulz <quentin.schulz@xxxxxxxxxxx> · Wed, 10 Oct 2018 08:43:51 +0200

Hi Wei Yongjun,

On Wed, Oct 10, 2018 at 02:00:24AM +0000, Wei Yongjun wrote:
> In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot SerDes muxing")

Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>

Thanks!
Quentin
Attachment:
signature.asc

Description: PGP signature