[bug report] jump_label: Annotate entries that operate on __init code earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ard Biesheuvel,

This is a semi-automatic email about new static checker warnings.

The patch 19483677684b: "jump_label: Annotate entries that operate on 
__init code earlier" from Sep 18, 2018, leads to the following Smatch 
complaint:

    kernel/jump_label.c:524 __jump_label_mod_update()
    error: we previously assumed 'm' could be null (see line 519)

kernel/jump_label.c
   518			m = mod->mod;
   519			if (!m)
                            ^^
Old code has check for NULL

   520				stop = __stop___jump_table;
   521			else
   522				stop = m->jump_entries + m->num_jump_entries;
   523			__jump_label_update(key, mod->entries, stop,
   524					    m->state == MODULE_STATE_COMING);
                                            ^^^^^^^^
New code adds unchecked dereference.

   525		}
   526	}

regards,
dan carpenter



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux