Re: [PATCH] scsi: qla2xxx: don't allow negative thresholds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sep 20, 2018, at 3:02 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 
> External Email
> 
> We shouldn't allow negative thresholds.  I don't know what it would do
> but it can't be good.
> 
> Fixes: 8b4673ba3a1b ("scsi: qla2xxx: Add support for ZIO6 interrupt threshold")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index a31d23905753..b28f159fdaee 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -1228,7 +1228,7 @@ qla_zio_threshold_store(struct device *dev, struct device_attribute *attr,
>                return -EINVAL;
>        if (sscanf(buf, "%d", &val) != 1)
>                return -EINVAL;
> -       if (val > 256)
> +       if (val < 0 || val > 256)
>                return -ERANGE;
> 
>        atomic_set(&vha->hw->zio_threshold, val);

Looks Good. 

Acked-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

Thanks,
- Himanshu





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux