Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 14, 2018 at 09:18:12AM -0700, Moritz Fischer wrote:
> Hi,
> 
> On Fri, Sep 14, 2018 at 3:23 AM, Wu Hao <hao.wu@xxxxxxxxx> wrote:
> > On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
> >> drivers/fpga/dfl-fme-pr.c:447:18: warning:
> >>  variable 'priv' set but not used [-Wunused-but-set-variable]
> >
> > Looks good to me, thanks for this fixing.
> 
> Hao, is this an Acked-by? :)

Sure.. thanks for reminding. :)

Acked-by: Wu Hao <hao.wu@xxxxxxxxx>

Hao

> >
> > Thanks
> > Hao
> >
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> Acked-by: Moritz Fischer <mdf@xxxxxxxxxx>
> >> ---
> >>  drivers/fpga/dfl-fme-pr.c | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> >> index 0b84053..fe5a557 100644
> >> --- a/drivers/fpga/dfl-fme-pr.c
> >> +++ b/drivers/fpga/dfl-fme-pr.c
> >> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
> >>                         struct dfl_feature *feature)
> >>  {
> >>       struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> >> -     struct dfl_fme *priv;
> >>
> >>       mutex_lock(&pdata->lock);
> >> -     priv = dfl_fpga_pdata_get_private(pdata);
> >>
> >>       dfl_fme_destroy_regions(pdata);
> >>       dfl_fme_destroy_bridges(pdata);
> 
> Thanks for the patch,
> 
> Moritz



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux