Re: [PATCH] scsi: lpfc: remove an unnecessary NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: lpfc: remove an unnecessary NULL check
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Thu, 30 Aug 2018 07:34:18 -0400
Cc: James Smart <james.smart@xxxxxxxxxxxx>, Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20180823135633.5qcevijtcalx76u6@kili.mountain> (Dan Carpenter's message of "Thu, 23 Aug 2018 16:56:33 +0300")
Organization: Oracle Corporation
References: <20180823135633.5qcevijtcalx76u6@kili.mountain>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Dan,

> Smatch complains about this code:
>
>     drivers/scsi/lpfc/lpfc_scsi.c:1053 lpfc_get_scsi_buf_s4()
>     warn: variable dereferenced before check 'lpfc_cmd' (see line 1039)
>
> Fortunately the NULL check isn't required so I have removed it.

Applied to 4.20/scsi-queue, thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] scsi: lpfc: remove an unnecessary NULL check
  - From: Dan Carpenter

Prev by Date: [PATCH] can: ucan: remove redundant pointer 'udev'
Next by Date: Re: [PATCH] fsl: remove redundant pointer 'priv'
Previous by thread: [PATCH] scsi: lpfc: remove an unnecessary NULL check
Next by thread: [PATCH] PM / clk: signedness bug in of_pm_clk_add_clks()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux